Proof of concept: Web Fonts API as an extension of WP_Dependencies #40556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -132 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
desrosj
force-pushed
the
desrosj/web-fonts-poc
branch
from
29683cb
to
a5ac6bf
Compare
11 tasks
14 tasks
|
Closing this out as it has been replaced by other PRs (See above). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
DO NOT MERGE
This is a proof of concept for the Web Fonts API as an extension of the
WP_Dependenciesclass.It doesn't work quite yet. This is mainly to gauge whether this would be a feasible option to pursue further.
Why?
The current implementation re-implements a lot of the concepts that are already handled by
WP_Dependenciesfor the script and style loaders. AWP_Web_Fontsclass could potentially cut down on a lot of the code needed to implement a web fonts API.The script loader classes already have the concepts of dependencies, enqueuing, and registering, as well as a way to "do_item()" (generate CSS or a
<link>tag with source, in this case).How?
This uses the following:
Testing Instructions
Screenshots or screencast