Element styles: prevent the WordPress filter callback from being executed #40594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
added
the
Global Styles
oandregal
requested review from
scruffian,
mikachan,
youknowriad,
ramonjd,
andrewserong and
glendaviesnz
|
LGTM Editor
Frontend
|
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow up to #37728
Stops a filter callback added by WordPress, as Gutenberg will take care of doing the same.
Why?
We don't want to end up enqueuing styles or attaching classes to blocks twice.
In #37728 we introduced a new filter callback for elements styles, which is being backported to core in WordPress/wordpress-develop#2624 This follow-up makes sure that the core callback is not executed in the Gutenberg plugin.
How?
Removes the filter callback added by WordPress.
Testing Instructions
The expected result is that both editor and front end show the paragraph link color as purple.