[RichText]: Ignore selection changes on non contentEditable nodes #40611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
ntsekouras
requested review from
mcsf,
youknowriad,
gziolo,
andrewserong and
aaronrobertshaw
|
Size Change: +12 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
|
Is this the same change I have in #40631 ? |
youknowriad
approved these changes
Apr 26, 2022
There was a problem hiding this comment.
Nice work tracking that one down @ntsekouras 👍 Thank you.
This tests as advertised and fixes #40358 for me.
Screen.Recording.2022-04-27.at.11.52.56.am.mp4
ntsekouras
deleted the
fix/ignore-selection-changes-in-not-contenteditable-nodes
branch
adamziel
pushed a commit
that referenced
this pull request
Apr 29, 2022
|
I cherry picked this change into |
adamziel
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes: #40358
We need to check if the implementor disabled editing because
contentEditabledoes disable input, but not text selection, so we must ignore selection changes. This was removed in #38892, but I think it was an oversight.Testing Instructions
paragraphblockScreenshots or screencast
Before
before.mov
After
after.mov
Notes
I'd like a sanity check here, as RichText is quite complex 😄