Remove Navigation Area block #40645
Merged
Remove Navigation Area block #40645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
requested review from
TimothyBJacobs,
spacedmonkey,
tellthemachines,
ajitbohra,
nerrad,
mkaz,
ryanwelcher and
juanmaguitar
as code owners
|
Size Change: -694 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
Practically none of it made it. This block made it to one Gutenberg release, and in another it was marked as experimental. Experimental blocks are not backported to core. The deprecation grace period for Gutenberg passed long ago. We're good to go here. ...that is, once the unit tests pass 😄 |
|
This looks pretty close @getdave! Just one more test: |
Yeh that is weird. I can't see it happening elsewhere but I raised this as a potential fix. What do you think? |
spacedmonkey
approved these changes
Apr 29, 2022
getdave
force-pushed
the
remove/deprecated-navigation-area-block
branch
from
52e311e
to
a54503e
Compare
skorasaurus
added
[Block] Navigation
adamziel
added
the
Backport to WP 6.7 Beta/RC
|
I cherry picked this change into |
adamziel
pushed a commit
that referenced
this pull request
May 3, 2022
* Remove all references to Navigation Area block * Remove rest init * Remove Nav Area from ts entities * Remove refs to Nav Areas from Core Data tests
adamziel
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removes the deprecated Navigation Area block introduced in #36178 and formally deprecated in #36727.
Why?
Navigation Areas were deprecated in #36727 and should now be removed entirely in line with best practices and also to clean up the Nav block code.
How?
Removes all references to the Nav Areas block from Gutenberg.
Question: some of this code may have made it into Gutenberg Core. What should we do here @adamziel?
Testing Instructions
Check for errors when loading Gutenberg and inserting a Nav block.
Screenshots or screencast