Experiment w/ Annotation Reducers, Selectors, Components #4068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ someone with tag access, please tag as 'in progress' for me. Thanks! :-) |
3 tasks
added 12 commits
December 20, 2017 09:00
- Register new post type: wp_annotation - Add REST API controller: WP_REST_Annotations_Controller - Add annotation utilties: WP_Annotation_Utils - Add unit tests: REST_Annotations_Controller_Test referencing: #3026
- `hierarchical=flat` - `hierarchical=threaded` - Enhance existing unit tests. - Add unit tests for hierarchical responses. - fix: Allow `parent=0` when checking permissions.
- Delete a post's annotations whenever the post itself is permanently deleted from the database. Attached to `delete_post`. - `WP_Annotation_Utils::$post_type` property for faster interal reads.
- Add `class-annotations-test.php` to cover `WP_Annotation_Utils` - Generate additional fake test data for all annotation unit tests. - Enhance unit tests that cover `WP_REST_Annotations_Controller`. - fix: In call to `register_post_type()`, the `read` cap should map to `edit_posts` for annotations.
Allows annotation substatus history length to be increased or decreased using a filter: `gutenberg_rest_annotation_substatus_history_length`
- If a user is the author of a post, and the only reason they can't edit the post is because they can't edit_published_posts, and the parent post's current status is `publish` or `future`, then allow the user to annotate. - Update unit tests to reflect revised permission strategy.
- Rename and repurpose `md5_email`. Now `image_url` with avatar URL. - Add readonly `author_meta` property with display name and avatar URL. - Allow `additionalProperties` in `annotator_meta` schema definition.
jaswrks
changed the title
jaswrks
changed the title
|
Is the work here still relevant, and can it be reasonably be brought up to date with current master? Or can we close it? |
aduth
added
the
[Status] Stale
|
Closing as stale without response. It can be reopened if development is expected to continue, or a new pull request can be submitted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding annotations to Gutenberg
Please note:
Types of changes
Checklist: