Code Editor: Commit changes upon switching editors to avoid content loss #40730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
Mamaduka
commented
Apr 29, 2022
ndiego
approved these changes
Apr 29, 2022
ndiego
added
the
Backport to WP 6.7 Beta/RC
|
Size Change: -678 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
|
Failing tests might be related to this change. |
Mamaduka
force-pushed
the
fix/text-editor-content-loss
branch
from
24592b1 to
986ae57
Compare
Mamaduka
commented
May 1, 2022
Mamaduka
commented
May 1, 2022
gziolo
added
the
[Priority] High
mcsf
reviewed
May 3, 2022
|
@Mamaduka Is this ready to backport to WordPress 6.0 RC2, or is there still some follow-up required? I'm not sure what to make of the recent discussion :-) |
|
Hi, @adamziel I think this is ready for RC backport. |
mcsf
changed the title
|
I cherry-picked this PR for WordPress 6.0 RC2 with |
gziolo
removed
the
Backport to WP 6.7 Beta/RC
gziolo
pushed a commit
that referenced
this pull request
May 6, 2022
* Text Editor: Avoid content loss * Update method * Fix unit tests * Avoid code duplication * Back to the side effects
This was referenced May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #40575.
PR fixes content loss issue when switching between editors mode using keyboard shortcuts.
How?
Currently, blocks are only updated
onBlur. I added a new effect to try and update them when the component unmounts.Testing Instructions