Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify allowed_block_types filter #4091

Conversation

greatislander
Copy link
Contributor

@greatislander greatislander commented Dec 19, 2017

Description

As per conversation in Slack, this PR updates the docblock of the allowed_block_types filter to clarify existing behaviour.

How Has This Been Tested?

This PR does not affect functionality; it just changes code comments for clarity.

Types of changes

This PR does not affect functionality; it just changes code comments for clarity.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

@aduth
Copy link
Member

aduth commented Dec 19, 2017

Rather than changing the documentation to reflect the current behavior, I'd be more inclined to file this as a bug where the allowed_block_types filter is not matching the expected behavior.

@greatislander
Copy link
Contributor Author

@aduth Cool. I'll close this PR and open an issue.

@greatislander greatislander deleted the try/clarify-allowed-block-types-filter branch December 19, 2017 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants