Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BorderControl: Make border color consistent with other controls #40921

Merged
merged 1 commit into from
May 10, 2022
Merged

BorderControl: Make border color consistent with other controls #40921

merged 1 commit into from
May 10, 2022

Conversation

aaronrobertshaw
Copy link
Contributor

Related:

What?

Makes the BorderControl and BorderBoxControl border colors consistent with other controls.

Only addresses the border color from #40893 in this PR as controlling the height might need discussion. See #40920.

Why?

Consistency is good.

How?

  • Set the BorderControl border colors to COLORS.ui.border.

Testing Instructions

  1. Edit a post, add a group block, and select it.
  2. Under the border settings in the sidebar check that the border control has the same border color as other controls

Screenshots or screencast

Before After
Screen Shot 2022-05-09 at 4 30 26 pm Screen Shot 2022-05-09 at 4 27 29 pm
Screen Shot 2022-05-09 at 4 18 58 pm Screen Shot 2022-05-09 at 4 27 14 pm

@aaronrobertshaw aaronrobertshaw added [Type] Enhancement A suggestion for improvement. [Feature] UI Components Impacts or related to the UI component system [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels May 9, 2022
@aaronrobertshaw aaronrobertshaw requested a review from ajitbohra as a code owner May 9, 2022 06:33
@aaronrobertshaw aaronrobertshaw self-assigned this May 9, 2022
@aaronrobertshaw aaronrobertshaw mentioned this pull request May 9, 2022
Closed
andrewserong
andrewserong approved these changes May 10, 2022
View reviewed changes
Copy link
Contributor

@andrewserong andrewserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The border colors now look more consistent with the other border and dimensions control inputs:

Before After
image image

@aaronrobertshaw aaronrobertshaw merged commit 83eed93 into trunk May 10, 2022
@aaronrobertshaw aaronrobertshaw deleted the update/border-control-border-color branch May 10, 2022 01:00
@github-actions github-actions bot added this to the Gutenberg 13.3 milestone May 10, 2022
@shaunandrews
Copy link
Contributor

Much better; Thanks!

@ciampo ciampo added the [Package] Components /packages/components label May 19, 2022
@ciampo ciampo mentioned this pull request May 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewserong andrewserong andrewserong approved these changes

@shaunandrews shaunandrews Awaiting requested review from shaunandrews

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@aaronrobertshaw aaronrobertshaw

Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] UI Components Impacts or related to the UI component system [Package] Components /packages/components [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 13.3
Development

Successfully merging this pull request may close these issues.
4 participants
@aaronrobertshaw @shaunandrews @andrewserong @ciampo