Post Comments: Fix Older/Newer comments links styling #40948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ockham
added
[Type] Bug
|
Size Change: +1.43 kB (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
jameskoster
approved these changes
May 10, 2022
Thanks James! 😄 Any thoughts on the small vertical whitespace between the "Older Comments" and "Leave a reply"? That one used to be quite a bit bigger before (see screenshot in PR desc). (Just a bit worried about proximity and whatnot 😅)
Thanks! While this sounds tempting, I feel like I need to stick with the |
Oh jeez I didn't even spot that. Yes, we should probably keep that the same if possible. |
@jameskoster Can you help me with that? 😅 I was looking into it but found it a bit hard to figure out. AFAICS, the original vertical space was because of some browser default for
I guess I could just force a top margin, but I was wondering how (pre-FSE and pre-GB) Core managed to get the space right with the clear-fix 🤔 |
|
If we apply a clearfix to
|
|
Thanks @jameskoster! Looking great now 😄 |
cbravobernal
approved these changes
May 12, 2022
ockham
added
the
Backport to WP 6.7 Beta/RC
adamziel
pushed a commit
that referenced
this pull request
May 16, 2022
Co-authored-by: James Koster <james@jameskoster.co.uk>
|
I just cherry-picked this PR to the wp/6.0 to get it included in the next release: f361ac9 |
adamziel
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #40827. Alternative approach to #40846; based on suggestions from comments on that PR.
Why?
See #40827. tl;dr:
Users that still have the now-deprecated Post Comments block in one of their templates will find that the "Older Comments" and "Newer Comments" links aren't left- and right-aligned like they should be, but stacked on top of each other.
How?
Add
.alignleftand.alignrightstyling to the Post Comments block'sstyle.css.Furthermore, add
clear: bothto the embedded comments form, in order to make sure that the "Leave a Reply" heading isn't accidentally indented.Testing Instructions
gutenberg/packages/block-library/src/post-comments/block.json
Line 37 in 54fd3bf
Screenshots or screencast
Notes
I guess it's called Cascading Style Sheets for a reason 😬
The
float: leftandfloat: rightstyling originally caused the "Leave a Reply" comments form heading to get wrongly indented. To fix this, I addedclear: bothto the comments form. As a consequence, the spacing between the "Older"/"Newer Comments" links and that heading now seems too small 🙈Ideally, we'd probably recreate the styling for Core's
theme-compat/comments.phpfallback; I wasn't able to figure out how the clear-fix is achieved there.Anyway, this could use some eyes from a designer 😅