3 column inserter #4095
Merged
3 column inserter #4095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a suggestion for #4080. It increases the 2 columns to 3 for the inserter.
|
Nice, I dig this. Though it's a bit cramped when it's just 300px wide:
The mobile safe area is 360px. If we make it 350px wide, it'll be more relaxed:
What do you think? |
Adds in a wider inserter.
|
I have now added in the titles and also widened the block:
|
|
Nice! 👍 👍 |
The left align wasn't working so lets move border and center align.
|
Hey I like it, what if the titles had a border-top as well
|
youknowriad
approved these changes
Dec 20, 2017
|
We tried the top border in the past, but then the topmost group would "stack" the borders. I think we tried some first-child magic to address that, but ran into woes. Not sure. |
|
For now let's get in the 1 border and pondering a 2. If we can find a good option for it, I like the clarity of 2 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a suggestion for #4080. It increases the 2 columns to 3 for the inserter.