Env: Restrict WP_TESTS_DOMAIN constant to just hostname and not home URL
#41039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.26 MB ℹ️ View Unchanged
|
gziolo
changed the title
WP_TESTS_DOMAIN constant to just hostname and not home URLWP_TESTS_DOMAIN constant to just hostname and not home URL
noahtallen
approved these changes
May 14, 2022
There was a problem hiding this comment.
Thanks for the change! I think we weren't completely clear on the meaning of WP_TESTS_DOMAIN when it was originally introduced. Additionally, we've had trouble when some of the URL-related config values don't including the port, so it was natural to apply the same treatment to this value.
|
@noahtallen Something I'm not sure about still here is the status it dumps in the console: Notice the dev site says it started at |
|
I see. It's because it's using |
8 tasks
noahtallen
approved these changes
May 23, 2022
noahtallen
reviewed
May 23, 2022
|
This is good to merge from my perspective 👍 |
Mamaduka
force-pushed
the
fix/env-wp-tests-config
branch
from
e2f23b2
to
86e3bf0
Compare
|
Resolved merge conflict, and I'm going to merge after all checks are green 👍 |
Co-authored-by: Noah Allen <noahtallen@gmail.com>
Mamaduka
force-pushed
the
fix/env-wp-tests-config
branch
from
e6f71a7
to
a7821f0
Compare
|
🎉 Tests are finally passing ✅ |
Closed
1 task
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41038.
What?
I found that unit tests were being run with
WP_TESTS_DOMAIN(and thus$_SERVER['HTTP_HOST']) being set to a URLhttp://localhost:8889/when it should be limited to just the hostname:localhost.Why?
Constructing the current URL often looks like:
This is completely broken if the
HTTP_HOSTis not just the host name.How?
Don't attempt to populate a URL in
WP_TESTS_DOMAIN.