Fix Storybook builds #41089
Merged
Fix Storybook builds #41089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
|
Size Change: -5 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
noisysocks
approved these changes
May 17, 2022
There was a problem hiding this comment.
This fixes npm run storybook:dev for me locally. Thanks @Mamaduka!
Do we not have a GitHubAction which builds storybooks? Would be nice to catch this before it's merged to trunk.
|
@noisysocks, I think action runs only on the trunk since it also builds the page - https://wordpress.github.io/gutenberg/. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow-up to #40998.
Fixes failing Storybook build on trunk. The space before minus was causing following error:
@jameskoster, I would appreciate code sanity check here, but I don't see any visual regression after this fix.
Testing Instructions