Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Box Control: Ensure Unlink tooltip position stays within the viewport #41176

Closed
wants to merge 2 commits into from
Closed

Box Control: Ensure Unlink tooltip position stays within the viewport #41176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
491c9cb
Box Control: Ensure Unlink tooltip position stays within the viewport
andrewserong May 20, 2022
497e4b6
Add changelog entry
andrewserong May 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/block-editor/src/components/border-radius-control/linked-button.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export default function LinkedButton( { isLinked, ...props } ) {
const label = isLinked ? __( 'Unlink Radii' ) : __( 'Link Radii' );

return (
<Tooltip text={ label }>
<Tooltip text={ label } position="bottom left">
<Button
{ ...props }
className="component-border-radius-control__linked-button"
Expand Down
4 changes: 4 additions & 0 deletions packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Bug fix

- `BoxControl` and `BorderBoxControl`: Ensure Unlink tooltip position stays within the viewport. ([#41176](https://github.com/WordPress/gutenberg/pull/41176))

## 19.11.0 (2022-05-18)

### Enhancements
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/border-box-control/border-box-control-linked-button/component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const BorderBoxControlLinkedButton = (
const label = isLinked ? __( 'Unlink sides' ) : __( 'Link sides' );

return (
<Tooltip text={ label }>
<Tooltip text={ label } position="bottom left">
<View className={ className }>
<Button
{ ...buttonProps }
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/box-control/linked-button.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export default function LinkedButton( { isLinked, ...props } ) {
const label = isLinked ? __( 'Unlink Sides' ) : __( 'Link Sides' );

return (
<Tooltip text={ label }>
<Tooltip text={ label } position="bottom left">
<span>
<Button
{ ...props }
Expand Down