Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome: Replace the publish dropdown by a sidebar panel #4119

Merged
merged 5 commits into from
Dec 22, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions editor/assets/stylesheets/_animations.scss
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,13 @@
50% { opacity: 1; }
100% { opacity: .5; }
}


@mixin slide_in_right {
transform: translateX(+100%);
animation: slide_in_right 0.1s forwards;
}

@keyframes slide_in_right {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are keyframes local to a CSS file? If not, would this need a gutenberg_ prefix?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmmm good question, I guess this applies to all of our animations. I wonder if there's a way to nest these animations. If not, it makes sense to add a prefix for me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do think animations are globally registered, so if registered once it's available everywhere the CSS is loaded.

It'd be nice to either have reusable animations, or well scoped ones.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! I'm inclined to leave this issue to a separate PR as it's global to all animations.

100% { transform: translateX(0%); }
}
1 change: 1 addition & 0 deletions editor/assets/stylesheets/_z-index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ $z-layers: (
// Show sidebar above wp-admin navigation bar for mobile viewports:
// #wpadminbar { z-index: 99999 }
'.editor-sidebar': 100000,
'.editor-layout .editor-post-publish-panel': 100001,

// Show notices below expanded wp-admin submenus:
// #adminmenuwrap { z-index: 9990 }
Expand Down
20 changes: 9 additions & 11 deletions editor/components/block-settings-menu/block-inspector-button.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,34 +13,32 @@ import { IconButton, withSpokenMessages } from '@wordpress/components';
/**
* Internal dependencies
*/
import { isEditorSidebarOpened, getActivePanel } from '../../store/selectors';
import { getActivePanel, isSidebarOpened } from '../../store/selectors';
import { toggleSidebar, setActivePanel } from '../../store/actions';

export function BlockInspectorButton( {
isSidebarOpened,
isDefaultSidebarOpened,
panel,
onToggleSidebar,
onOpenSidebar,
onShowInspector,
onClick = noop,
small = false,
speak,
} ) {
const toggleInspector = () => {
onShowInspector();
if ( ! isSidebarOpened || ( isSidebarOpened && panel === 'block' ) ) {
onToggleSidebar();
}
onOpenSidebar( undefined, true );
};

const speakMessage = () => {
if ( ! isSidebarOpened || ( isSidebarOpened && panel !== 'block' ) ) {
if ( ! isDefaultSidebarOpened || ( isDefaultSidebarOpened && panel !== 'block' ) ) {
speak( __( 'Additional settings are now available in the Editor advanced settings sidebar' ) );
} else {
speak( __( 'Advanced settings closed' ) );
}
};

const label = ( isSidebarOpened && panel === 'block' ) ? __( 'Hide Advanced Settings' ) : __( 'Show Advanced Settings' );
const label = ( isDefaultSidebarOpened && panel === 'block' ) ? __( 'Hide Advanced Settings' ) : __( 'Show Advanced Settings' );

return (
<IconButton
Expand All @@ -56,15 +54,15 @@ export function BlockInspectorButton( {

export default connect(
( state ) => ( {
isSidebarOpened: isEditorSidebarOpened( state ),
isDefaultSidebarOpened: isSidebarOpened( state ),
panel: getActivePanel( state ),
} ),
( dispatch ) => ( {
onShowInspector() {
dispatch( setActivePanel( 'block' ) );
},
onToggleSidebar() {
dispatch( toggleSidebar() );
onOpenSidebar() {
dispatch( toggleSidebar( undefined, true ) );
},
} )
)( withSpokenMessages( BlockInspectorButton ) );
3 changes: 2 additions & 1 deletion editor/components/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ export { default as PostPingbacks } from './post-pingbacks';
export { default as PostPreviewButton } from './post-preview-button';
export { default as PostPublishButton } from './post-publish-button';
export { default as PostPublishButtonLabel } from './post-publish-button/label';
export { default as PostPublishWithDropdown } from './post-publish-with-dropdown';
export { default as PostPublishPanel } from './post-publish-panel';
export { default as PostPublishPanelToggle } from './post-publish-panel/toggle';
export { default as PostSavedState } from './post-saved-state';
export { default as PostSchedule } from './post-schedule';
export { default as PostScheduleLabel } from './post-schedule/label';
Expand Down
81 changes: 0 additions & 81 deletions editor/components/post-publish-dropdown/index.js

This file was deleted.

30 changes: 0 additions & 30 deletions editor/components/post-publish-dropdown/style.scss

This file was deleted.

94 changes: 94 additions & 0 deletions editor/components/post-publish-panel/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,94 @@
/**
* External dependencies
*/
import { connect } from 'react-redux';

/**
* WordPress dependencies
*/
import { __ } from '@wordpress/i18n';
import { compose } from '@wordpress/element';
import { withAPIData, PanelBody, IconButton } from '@wordpress/components';

/**
* Internal Dependencies
*/
import './style.scss';
import PostVisibility from '../post-visibility';
import PostVisibilityLabel from '../post-visibility/label';
import PostSchedule from '../post-schedule';
import PostScheduleLabel from '../post-schedule/label';
import PostPublishButton from '../post-publish-button';
import PostSwitchToDraftButton from '../post-switch-to-draft-button';
import { getCurrentPostType } from '../../store/selectors';

function PostPublishPanel( { onClose, user } ) {
const canPublish = user.data && user.data.capabilities.publish_posts;

return (
<div className="editor-post-publish-panel">
<div className="editor-post-publish-panel__header">
<div className="editor-post-publish-panel__header-publish-button">
<PostPublishButton onSubmit={ onClose } />
</div>
<IconButton
onClick={ onClose }
icon="no-alt"
label={ __( 'Close Publish Panel' ) }
/>
</div>

<div className="editor-post-publish-panel__content">
<div><strong>{ __( 'All ready to go?' ) }</strong></div>
<p>{ __( 'Here, you can do a last-minute check up of your settings below, before you publish.' ) }</p>
{ ! canPublish &&
<div>
<span>{ __( 'Visibility' ) }</span>
<span><PostVisibilityLabel /></span>
</div>
}
{ canPublish &&
<PanelBody initialOpen={ false } title={ [
__( 'Visibility: ' ),
<span className="editor-post-publish-panel__link" key="label"><PostVisibilityLabel /></span>,
] }>
<PostVisibility />
</PanelBody>
}
{ canPublish &&
<PanelBody initialOpen={ false } title={ [
__( 'Publish: ' ),
<span className="editor-post-publish-panel__link" key="label"><PostScheduleLabel /></span>,
] }>
<PostSchedule />
</PanelBody>
}
</div>

<div className="editor-post-publish-panel__footer">
<PostSwitchToDraftButton />
</div>
</div>
);
}

const applyConnect = connect(
( state ) => {
return {
postType: getCurrentPostType( state ),
};
},
);

const applyWithAPIData = withAPIData( ( props ) => {
const { postType } = props;

return {
user: `/wp/v2/users/me?post_type=${ postType }&context=edit`,
};
} );

export default compose( [
applyConnect,
applyWithAPIData,
] )( PostPublishPanel );
61 changes: 61 additions & 0 deletions editor/components/post-publish-panel/style.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
.editor-post-publish-panel {
background: $white;
color: $dark-gray-500;
}

.editor-post-publish-panel__content {
padding: 16px;

.components-panel__body {
margin-left: -16px;
margin-right: -16px;
margin-bottom: -16px;
margin-top: 10px;
border: none;

.components-panel__body-toggle {
font-weight: normal;
}
}

.editor-post-visibility__dialog-legend {
display: none;
}
}

.editor-post-publish-panel__header {
padding-left: 16px;
height: $header-height;
border-bottom: 1px solid $light-gray-500;
display: flex;
align-items: center;
align-content: space-between;
}

.editor-post-publish-panel__header-publish-button {
flex-grow: 1;
text-align: right;
}

.editor-post-publish-panel__footer {
padding: 16px;
}

.wp-core-ui .editor-post-publish-panel__toggle.button-primary {
margin: 0 10px;
display: inline-flex;
align-items: center;

&.is-busy .dashicon {
display: none;
}

.dashicon {
margin-right: -4px;
}
}

.editor-post-publish-panel__link {
color: $blue-medium-700;
text-decoration: underline;
}
Loading