-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table of Contents block: convert <br>
tags to spaces in headings.
#41206
Merged
ZebulanStanphill
merged 1 commit into
trunk
from
fix/table-of-contents-newline-handling
May 22, 2022
Merged
Table of Contents block: convert <br>
tags to spaces in headings.
#41206
ZebulanStanphill
merged 1 commit into
trunk
from
fix/table-of-contents-newline-handling
May 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZebulanStanphill
added
[Type] Bug
An existing feature does not function as intended
[Block] Table of contents (experimental)
Affects the Table of contents Block
[Package] Block library
/packages/block-library
Good First Review
A PR that's suitable for someone looking to contribute for the first time by reviewing code
labels
May 20, 2022
Size Change: +14 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
amustaque97
approved these changes
May 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on the fix. I tested the fix locally. It is working as expected.
ZebulanStanphill
force-pushed
the
fix/table-of-contents-newline-handling
branch
from
May 21, 2022 23:00
1abb552
to
96dad17
Compare
westonruter
added a commit
that referenced
this pull request
May 23, 2022
…p-tests-config * 'trunk' of github.com:WordPress/gutenberg: (88 commits) Components: refactor `AlignmentMatrixControl` to pass `exhaustive-deps` (#41167) [RNMobile] Add 'Insert from URL' option to Image block (#40334) [RNMobile] Improvements to Getting Started Guides (#40964) Post Author Name: Add to and from Post Author transformations (#41151) CheckboxControl: Add unit tests (#41165) Improve inline documentation (#41209) Mobile Release v1.76.1 (#41196) Use explicit type definitions for entity configuration (#40995) Scripts: Convert file extension to js in `block.json` during build (#41068) Reflects revert in 6446878 (#41221) get_style_nodes should be compatible with parent method. (#41217) Gallery: Opt-in to axial (column/row) block spacing controls (#41175) Table of Contents block: convert line breaks to spaces in headings. (#41206) Add support for button elements to theme.json (#40260) Global Styles: Load block CSS conditionally (#41160) Update URL (#41188) Improve autocompleter performance (#41197) Site Editor: Set min-width for styles preview (#41198) Remove Navigation Editor screen from experiments page (#40878) Fix broken Page title for pages created inline within in Nav block (#41063) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Table of contents (experimental)
Affects the Table of contents Block
Good First Review
A PR that's suitable for someone looking to contribute for the first time by reviewing code
[Package] Block library
/packages/block-library
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #41203.
Why?
Because it looks a bit weird to have two lines be bunched up together on a single line with no space between.
How?
Any sequence of one or more
<br>
tags is converted to a space.https://regex101.com/r/1FVE7p/1
Testing Instructions
Screenshots or screencast