-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate html block test case to Playwright #41231
Migrate html block test case to Playwright #41231
Conversation
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @pooja-muchandikar! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
Hi @kevin940726 The CI seems to be failing but the error is on the test case which I didn't even alter. Can you please help me reviewing this PR? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! The error seems to come from a flaky test. I think we can ignore it :)
Hi @kevin940726, The feedbacks are addressed, please take a look. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you again!
Don't mind me, I'm just adding some nitpicking line breaks 😆.
Oops, I didn't notice that this is a duplicate of #41127. I think we can still merge this one though, but it'd be nice to check out if the work has already been started by someone next time :) |
Oh no 😒 sorry I didn't notice that. I had created PR few days back #40843 but unfortunately I had to close it yesterday and create new one. I will take care of this next time 😐 |
Congratulations on your first merged pull request, @pooja-muchandikar! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts: https://profiles.wordpress.org/me/profile/edit/ And if you don't have a WordPress.org account, you can create one on this page: https://login.wordpress.org/register Kudos! |
What?
Part of #38851.
Migrate html-test.js to its Playwright version.
Why?
Part of #38851.
How?
See MIGRATION.md for migration steps.
Testing Instructions
Run
npm run test-e2e:playwright test/e2e/specs/editor/blocks/html.spec.js