Allow removing bottom margin from SelectControl #41269
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Allows removing the bottom margin from
SelectControl
by specifying a__nextHasNoMarginBottom
prop.Why?
@wordpress/components
is slowly transitioning away from this.SelectControl
in Design updates to the Publish popover (DateTimePicker
) #41097.How?
BaseControl
already has a__nextHasNoMarginBottom
prop so the approach here is to just use that fromSelectControl
.I am not adding a call to
deprecate()
as there are dozens of uses ofSelectControl
in Gutenberg that need to be adjusted first. This is also the approach that was taken withBaseControl
.Testing Instructions
npm run storybook:dev
SelectControl
component.__nextHasNoMarginBottom
removes the bottom margin from the control's wrapper.