Upgrade Rememo to v4 #41415
Merged
Upgrade Rememo to v4 #41415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
requested review from
ellatrix,
fluiddot,
ajitbohra,
atimmer and
nerrad
as code owners
|
Size Change: -328 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
cbravobernal
added
the
[Type] Code Quality
youknowriad
pushed a commit
that referenced
this pull request
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Upgrades the
rememodependency to the latest version, across all packages.Why?
The latest version includes type definitions, which ensures that functions created through
createSelectorretain the original function type of the function being memoized.Related discussion: #41235 (comment)
It's also ever-so-slightly smaller, as it removes IE10 compatibility code (aduth/rememo@68ad3b5).
How?
Updates packages.
Testing Instructions
npm installnpx tsc