-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Button Block tests to Playwright #41494
Migrate Button Block tests to Playwright #41494
Conversation
Hi @kevin940726 👋 Please help me in reviewing this PR!! Have a nice day ahead! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making this PR! Some suggestions about using role selectors here and there but overall it looks good 👍 !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some styling nitpicks left and then we can merge it! Thanks for the hard work!
Not sure why the e2e tests are failing. Seems unrelated though. Could you help rebase it to the latest trunk and try again? |
Hi @kevin940726, I rebased the latest trunk and pushed the changes, but seems like the CI is failing. But not on the test case I worked on. |
Yeah, that's unrelated and is being tracked in #37976 👍 |
Ok great!, any other changes required for this PR? |
Nope, looks perfect to me! Tests are failing but look unrelated to this PR so I think we can merge this 👍 @talldan, could you help merge it? |
I re-ran the tests, and the navigation block tests are still failing. They're unrelated to this PR so I'll merge it, and I'll also look at migrating the navigation block tests to playwright this week. Maybe that'll improve stability. |
Thank you @kevin940726 @talldan 🙇🏻♀️ |
What?
Part of #38851.
Migrate button-test.js to its Playwright version.
Why?
Part of #38851.
How?
See MIGRATION.md for migration steps.
Testing Instructions
Run
npm run test-e2e:playwright test/e2e/specs/editor/blocks/button.spec.js