-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experiment: ToolsPanel: Try moving the menu off the sidebar to improve UX #41523
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +179 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
Closing this exploration due to its age. Any change in approach needs to be based off and consider the current situation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experimental PR only and isn't intended for final review until design considerations and alternatives are taken into acccount.
Related:
What?
Allows the
ToolsPanel
menu to be positioned and moves the menu's popover off the sidebar within the editor.Why?
Moving the menu off the sidebar within the editor aims to minimise some current UX problems.
See #41376 for more details on problems.
How?
menuPosition
,popoverPlacement
, andpopoverOffset
props to theToolsPanel
.ToolsPanelHeader
ToolsPanel
to move the menu toggle to the left of the panel header and position the menu's popover to the left of the sidebarTesting Instructions
Screenshots or screencast
Screen.Recording.2022-06-03.at.12.46.41.pm.mp4