Lodash: Refactor away from _.random()
#41634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
swissspidy,
adamsilverstein,
chad1008 and
fabiankaegy
tyxla
commented
Jun 9, 2022
| @@ -19,6 +14,12 @@ import { | |||
| const TAG_TOKEN_SELECTOR = | |||
| '.components-form-token-field__token-text span:not(.components-visually-hidden)'; | |||
|
|
|||
| function generateRandomNumber() { | |||
There was a problem hiding this comment.
We're intentionally not parametrizing this function, since:
- It's only used for testing purposes.
- In each call, it always uses the same arguments, so we're keeping it simple.
| function generateRandomNumber() { | ||
| // Using `Math.random()` directly is fine in this testing context. | ||
| // eslint-disable-next-line no-restricted-syntax | ||
| return Math.round( 1 + Math.random() * ( Number.MAX_SAFE_INTEGER - 1 ) ); |
There was a problem hiding this comment.
We're definitely not generating a unique component instance here, which is why we're intentionally disabling this rule.
Since this looks like a false alarm, it could present an opportunity to improve the ESLint rule. Not anything urgent or directly related to the purpose of this PR, anyway.
|
Size Change: 0 B Total Size: 1.24 MB ℹ️ View Unchanged
|
andrewserong
approved these changes
Jun 10, 2022
There was a problem hiding this comment.
Thanks for taking on these lodash removal PRs @tyxla! ✨
This change LGTM, it appears the random function was only used to generate random tag names to avoid collisions when creating new tags? The level of randomness appears to be reasonably safe to me in this test, and the tests are passing 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Lodash's
randomis used only once in the entire codebase. This PR aims to remove that usage.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
Removing
randomis straightforward in favor of a simpleMath-based implementation.Testing Instructions
This only touches the taxonomies e2e test suite, so verify those still pass.