Migrate missing block tests to Playwright #41680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
commented
Jun 12, 2022
| const block = window.wp.blocks.parse( | ||
| `<!-- wp:non-existing-block-here --><img src onerror=alert(1)>` | ||
| ); | ||
| window.wp.data.dispatch( 'core/block-editor' ).resetBlocks( block ); |
There was a problem hiding this comment.
Originally, setPostContent from e2e-test-utils was used.
However, since this utility is used infrequently, I didn't migrate this utility and rewritten to a similar process.
t-hamano
added
the
[Type] Automated Testing
|
Size Change: 0 B Total Size: 1.25 MB ℹ️ View Unchanged
|
|
The unit test fails, but should pass if #41675 is merged. |
t-hamano
force-pushed
the
add/playwright-editor-missing-test
branch
from
078d9eb
to
a382219
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #38851. Migrate
missing.test.jsto Playwright.Why?
See this post for an overview of the migration.
How?
By following the migration guide.
Testing Instructions