TextHighlight: Convert component to TypeScript #41698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walbo
added
[Type] Enhancement
|
Size Change: +8 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
walbo
commented
Jun 13, 2022
mirka
approved these changes
Jun 15, 2022
ciampo
reviewed
Jun 17, 2022
| * ); | ||
| * ``` | ||
| */ | ||
| export const TextHighlight = ( props: TextHighlightProps ) => { |
There was a problem hiding this comment.
This is an interesting example of how ref forwarding and using the WordPressComponentProps type don't make much sense with the current way the component is written (cc @mirka )
Co-authored-by: Lena Morita <lena@jaguchi.com>
|
Anything else I need to address here? Would love to get a final review after the last commits. |
Hey @walbo ! Lena is currently AFK, and I'm catching up with all the PR review requests that I accumulated during the past week while I was AFK. I'll try to get to this PR (and the others that you have open) as quickly as possible! Thank you for your patience 🙏 |
Thanks for the review! No worries. No rush for me. ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Converts the
TextHighlightcomponent to TypeScript.Why?
Part of the @wordpress/components's TypeScript migration (#35744).
How?
TextHighlightto TypeScript.@testing-library/react'Testing Instructions
TextHighlightcontinues to function as expected