Migrate Navigation block color controls to Block Supports #42092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +470 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
6 tasks
getdave
changed the title
|
I'm currently a but unsure of how to proceed:
Many questions to answer... |
scruffian
force-pushed
the
update/migrate-nav-block-color-supports
branch
from
81c25e8
to
a9c56cb
Compare
getdave
force-pushed
the
update/migrate-nav-block-color-supports
branch
2 times, most recently
from
abe90d0
to
1654167
Compare
getdave
force-pushed
the
update/migrate-nav-block-color-supports
branch
from
1654167
to
984d7b8
Compare
|
Note that #44578 has recently patched the core problem here but it doesn't solve the fundamental underlying issue that we need to move the block to use block supports for color. |
|
Thanks for tackling this @getdave 👍
This doesn't have to be the case. The block support controls are rendered via SlotFills into their respective panels. You can leverage the Hope this helps a little! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Migrates Nav block text / link color to Global Styles implementation.
Also allows Nav block link styles to overide those defined on ancestor blocks.
Fixes #41146Part of #44712
TBC.
Why?
The Nav block uses a non-standard, custom implementation of the
Colorcontrols.It is also using an implicit CSS rule (
color: inherit) to propagate the value ofText Colordown onto its Linkaelements. Unfortunately this means that anyLinkrules from Global Styles and/or ancestor blocks which targetawill overwrite the implicit rules defined by the block because the global styles rules are output after the block rules.How?
This PR deprecates the existing bespoke Text Color attributes and migrates any colors defined on those attributes over to the
styles.elements.link.colors.textattribute of the block and thetextColorattribute provided by block supports.This PR aims to fix that by utilising the standards based Block Supports
colorimplementation. This provides:...colors.
It also moves the custom Submenu/Overlay color controls into their own panel. This is suboptimal UX wise but is the simplest option to get the majority of the block over to standards.
Please see #41146 (comment) for full context and explaination on what we're trying to achieve here.
Testing Instructions
Screenshots or screencast