Improve cache and performance of get_user_data_from_wp_global_styles.
#42152
Conversation
| $gs_query = new WP_Query(); | ||
| $recent_posts = $gs_query->query( $args ); | ||
| if ( count( $recent_posts ) === 1 ) { | ||
| $user_cpt = get_post( $recent_posts[0], ARRAY_A ); |
There was a problem hiding this comment.
This fixes an issue, where a WP_Post object is returned.
| ), | ||
| true | ||
| ); | ||
| if ( ! is_wp_error( $cpt_post_id ) ) { |
There was a problem hiding this comment.
This check should always have been here. WP_Insert_post can sometimes return a WP_Error.
There was a problem hiding this comment.
What happens if is_wp_error is true? It seems it remains empty array and we count on array with length zero to be evaluated to false. Could we make this clear in code?
| ); | ||
|
|
||
| $cache_key = sprintf( 'wp_global_styles_%s', md5( serialize( $args ) ) ); | ||
| $post_id = (int) get_transient( $cache_key ); |
There was a problem hiding this comment.
Use transient is better for performance here. Most sites do not run object caches. Transinets save to options table and will have 3 database queries per page load.
| if ( $post_id > 0 && in_array( get_post_status( $post_id ), (array) $post_status_filter, true ) ) { | ||
| return get_post( $post_id, ARRAY_A ); | ||
| } |
There was a problem hiding this comment.
Improve handling of post status changed. If this post is deleted or changed to draft.
| 'post_status' => 'publish', | ||
| 'post_title' => __( 'Custom Styles', 'default' ), | ||
| 'post_type' => $post_type_filter, | ||
| 'post_name' => 'wp-global-styles-' . urlencode( wp_get_theme()->get_stylesheet() ), |
There was a problem hiding this comment.
The addition of sprintf from https://github.com/WordPress/wordpress-develop/pull/2414/files#diff-d6b86476eed058e7cf8b6e57fa52c4fd75b1f0907e1a9ccb0149528a24f7578bR298 seems legit. Shouldn't this be a copy of that other PR?
|
Love to get this into WP 6.1 cc @draganescu |
|
@spacedmonkey Now that |
|
Closed in favour of #44290 |
What?
Trac ticket: https://core.trac.wordpress.org/ticket/55392
Orignal PR - WordPress/wordpress-develop#2414
Why?
How?
Testing Instructions
Screenshots or screencast