Avoid intermitent failures in Comments block tests #42164
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.25 MB ℹ️ View Unchanged
|
|
FWIW, I thought I’d pick up work on migrating this test to Playwright again (which is overall supposed to be stabler with regard to failures like these). If anyone is curious and/or wants to chip in: #39826 |
3 tasks
|
Closing this as the test suite was migrated to Playwright. See #39826 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Some random failures are happening in the
comments.test.jsspec file (example). This PR tries to address that issue.Why?
The failing tests could give the (false?) impression that related blocks are not properly working when they are. (They are, right?).
How?
We're using
page.$()in that test. Looking at the documentation, it seems that that function doesn't wait for an element to exist, so it could be failing before it happens?To avoid that issue, I've replaced
page.$()withexpect( page ).toMatchElement(docs here), fromexpect-puppeteer(which is already installed).That is the approach I've followed. We can explore other alternatives, of course. 🙂
Testing Instructions
I'm not sure how to test this, TBH. I wasn't able to reproduce the original issue locally. Tests pass as expected with this PR's changes, but I'm not 100% sure this is going to work always on the GH tests workflows.