Components: Remove _.flatMap() from ToolbarGroup and TreeSelect
#42223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
mirka,
aristath,
gziolo,
swissspidy,
ciampo,
chad1008,
andrewserong,
ntsekouras and
fabiankaegy
tyxla
force-pushed
the
remove/components-lodash-flatmap
branch
from
5f9d445 to
5c682dd
Compare
|
Size Change: +4 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
tyxla
force-pushed
the
remove/components-lodash-flatmap
branch
2 times, most recently
from
072a267 to
7e9aeca
Compare
tyxla
force-pushed
the
remove/components-lodash-flatmap
branch
from
7e9aeca to
05e40d8
Compare
aristath
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes the
_.flatMap()usage from theToolbarGroupandTreeSelectcomponents. The PR looks larger than expected, but most is just whitespace change, caused byprettier.Together with #42219 and #42218, this removes most of the
_.flatMap()usage. The rest can be removed in a single PR after those are merged.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're replacing it with a
map()on the arrays, followed by a.flat()to flatten the result array.Testing Instructions
npm run test-unit packages/components/src/toolbar-groupToolbarGroupandTreeSelectin storybook.