Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor InserterMenu & VisualEditorInserter; allow recent/frequent reusable blocks to be inserted #4224

Closed
wants to merge 4 commits into from

Commits on Jan 12, 2018

  1. Refactor the inserter and quick inserter

    Changes the main inserter and the quick inserter to both use common
    selectors which determine which items that should appear for insertion.
    This means that common logic (e.g. is this block enabled?, has this
    block already been used?) can be shared between the two inserters.
    
    At the same time, also allow Reusable Blocks to appear in the MRU and
    MFU inserter lists.
    noisysocks committed Jan 12, 2018
    Configuration menu
    Copy the full SHA
    0fb8791 View commit details
    Browse the repository at this point in the history
  2. Remove usage stats for reusable blocks that are removed

    When a reusable block is deleted, remove that block from recentInserts
    and frequentInserts.
    noisysocks committed Jan 12, 2018
    Configuration menu
    Copy the full SHA
    e5761b3 View commit details
    Browse the repository at this point in the history
  3. Use underlying icon for reusable blocks

    Use the underlying block type's icon as the icon that displays in an
    inserter for a reusable block.
    noisysocks committed Jan 12, 2018
    Configuration menu
    Copy the full SHA
    d884f71 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1fd2ff3 View commit details
    Browse the repository at this point in the history