Add setting to display rich text toolbar inline #42399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +179 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
draganescu
approved these changes
Jul 14, 2022
There was a problem hiding this comment.
I think this is working great. Left a wording suggestion to the setting. However there is something about the interaction that does not feel right when the toolbar:
- shows up below the selection (everything else is on top of the current insertion point)
- shows up alongside the block toolbar? Maybe we could hide the block toolbar when
a) this preference is on
b) text is selected
However code wise it's all 👍🏻
draganescu
added
[Type] Enhancement
We do the same for the link UI. This shows below the link as well. I think this was done to not overlap with the block toolbar. |
ellatrix
force-pushed
the
try/rich-text-inline-toolbar
branch
from
fea3e6e to
7df9544
Compare
|
I am using the Gutenberg PR build but I am not able to get the expected result. I am double clicking text and I am not seeing the inline toolbar when the word is selected. |
|
@paaljoachim the setting in the UI was removed, so you can't test this currently (there's probably a code snippet, but I'm not sure :D). I believe there is an intention to add the setting back and refine the UX in a subsequent PR. |
|
Alrighty! Thanks for the heads up James! |
|
It's for #41740 |
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds a setting to display the rich text toolbar inline, meaning next to selected text when there is selection.
Why?
This can be automatically enabled when distraction free writing is enabled (#41740).
This option makes sense on its own too for people that prefer this interface style. It might even make sense to do this by default in the future. The rich text button is not really useful to be display all of the time.
How?
With
useAnchorRefit's easy to render the toolbar at the selection.Testing Instructions
Type some text. Try selecting with Shift+Alt+Arrow. The toolbar should appear. Try also selecting with the mouse.
Screenshots or screencast