Improve the headings hierarchy in the site editor page #42495
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
|
Size Change: +19 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
afercia
force-pushed
the
fix/site-editor-page-headings-hierarchy
branch
from
982b607 to
f757a39
Compare
afercia
force-pushed
the
fix/site-editor-page-headings-hierarchy
branch
from
f757a39 to
a9d383e
Compare
afercia
force-pushed
the
fix/site-editor-page-headings-hierarchy
branch
from
a9d383e to
d04251e
Compare
|
Rebased and adjusted on top of latest trunk. |
|
Flaky tests detected in d04251e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4045143620
|
afercia
force-pushed
the
fix/site-editor-page-headings-hierarchy
branch
from
d04251e to
873f4b5
Compare
|
I rebased and adjusted on top of latest trunk. The pending issue about the main H1 can be split into a separate issue. In the meantime, I'd love to see this PR merged ❤️ |
afercia
force-pushed
the
fix/site-editor-page-headings-hierarchy
branch
from
388e53b to
5443f4c
Compare
|
@afercia If you can rebase this one more time, I'll give it a quick review/approve. Happy to see this go in even if we're still trying to figure out the h1. Sorry, I was under the impression that the h1 discussion needed resolution first. Did not mean to leave you hanging here. |
|
@alexstine @afercia any updates here? We are running out of time to get this included in 6.3. Thanks! |
|
I am on a working vacation right now so do not have time to take on additional work. :( |
|
@ndiego thanx for the ping. Part of the headings hierarchy was already improved by @youknowriad in #51696 I think there's still room for improvements but I'll split them in a future PR. More importantly, the CSS adjustments included in this PR need to ship to fix the WP admin page See: Screenshot of the 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42373
What?
Navigationsub-componentsNavigationMenuandNavigationGroupdon't render an emptyaria-labelledbyattribute. Note: this component is no longer used. It was in use when this PR was first crafted. Keeping this change as it's a simple improvement.Why?
A good headings structure is not just about good semantics. Headings are also a navigational tool for screen reader users, as they can use dedicated commands to jump through headings, get a sense of the overall content, and navigate a page. This principle applies also to administration user interfaces, where headings can be used to identify the main parts of the interface.
How?
Updated testing Instructions
Navigatorcomponent that replacedNavigation.#wpadminbaris not hidden withdisplay: none;and the admin menu is not partially hidden behing the admin bar. This is in preparation for https://core.trac.wordpress.org/ticket/56228.Old Instructions
Screenshots or screencast