-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Correct alt text footnote spacing #42504
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a space between the two sentences of the alt text footnote. A space was lacking between the two sentences within the alt text footnote. This occurred due to the way React parses the separate link element found within this particular footnote. Originally an appropriate space was included in the first sentence, but it was accidentally removed entirely within #38115 to avoid i18n script errors.
dcalhoun
added
Mobile App - Automation
Label used to initiate Mobile App PR Automation
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
[Type] Regression
Related to a regression in the latest release
labels
Jul 18, 2022
Size Change: 0 B Total Size: 1.26 MB ℹ️ View Unchanged
|
fluiddot
approved these changes
Jul 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, LGTM 🎊 !
I tested the changes in both Android and iOS platforms and worked as expected ✅ .
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Mobile App - Automation
Label used to initiate Mobile App PR Automation
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
[Type] Regression
Related to a regression in the latest release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs
What?
Add a space between the two sentences of the alt text footnote.
Why?
A space was lacking between the two sentences within the alt text footnote. This occurred due to the way React parses the separate link element found within this particular footnote. Originally an appropriate space was included in the first sentence, but it was accidentally removed entirely within #38115 to avoid i18n script errors.
How?
Place the required space character in a separate expression. This achieves the appropriate sentence spacing, but avoids i18n script errors caused by trailing spaces within translation strings.
Testing Instructions
Screenshots or screencast