Layout: Try removing body element from base layout rules #42518
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Type] Code Quality
|
In testing, I actually think we probably need the For example, in this branch, the Column block's bottom margin takes precedence, where we actually want the base layout's gap rule to take effect:
@tellthemachines just pinging you since you'd brought up exploring removing the Let me know if you think it's still worth pursuing, otherwise I think I might close out this exploration for now. |
|
Size Change: -1 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
|
Thanks for trying this out!
Yeah, looks like we might have to do so. Would that margin on the Columns block be necessary for block themes, or only for classic themes I wonder? Perhaps at some point we could work out what styles we no longer need for block themes and serve them only if a classic theme is detected? In any case, yes, I think we can shelve this for now as it doesn't look like it's immediately doable! |
|
Thanks for taking a look!
Yes, I think there's more intuitive work we can do surrounding this. In my mind, ideally, if we're using layout spacing everywhere in blocks-based themes, individual blocks shouldn't be providing their own margins. It'd be good to come back to that kind of idea once layouts have progressed a bit further. I'll close this one out. Thanks again! |
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
🚧 🚧 🚧 🚧 WIP: This is an exploration at the moment 🚧 🚧 🚧 🚧
Part of #39336 and following on from a suggestion in https://github.com/WordPress/gutenberg/pull/40875/files#discussion_r914497178.
This PR removes
bodyfrom the base layout rules such as.is-layout-flowand.is-layout-flex.Why?
The premise is that we only need to prefix the Layout rules with the selector when the selector is for a particular block, the base layout rules only need to be attached to the Layout type's classname — specifying the Layout rules as being a descendant of
bodyis unnecessary.How?
Update the Layout rules to remove the selector from the rule construction when the selector is the root block selector.
Testing Instructions
Screenshots or screencast