AnglePickerControl: Fix gap between elements in RTL mode #42534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walbo
added
[Type] Bug
|
Size Change: +1 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
ciampo
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The
AnglePickerControluses inline css to define the space between the elements instead of using the build in gap prop of theFlexcomponent. The result of this is that in RTL mode there is a space to the left of the component and the gap is not the same.Why?
Makes the gap the same in LTR and RTL.
How?
Use build-in gap feature in
Flexto define the gap.Testing Instructions
AnglePickerControl.