Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluid typography: migrate fluid typography algorithm to JS for site editor #42688

Merged
merged 4 commits into from
Jul 27, 2022

Commits on Jul 26, 2022

  1. Migrate fluid typography algorithm from PHP version of `gutenberg_get…

    …_typography_font_size_value` to JS.
    
    We have to do this because the site editor is contained within an iframe and cannot, therefore, access the global CSS presets in the parent window.
    ramonjd committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    3d2b9c3 View commit details
    Browse the repository at this point in the history
  2. Remove var_dump. YOLO!

    ramonjd committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    85c9fd4 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2022

  1. Every preset metadata object needs a valueKey property and value so…

    … that the site editor can fetch values from the preset objects. Most notably these operations takes place in getValueFromPresetVariable() and getValueFromVariable()
    ramonjd committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    554c993 View commit details
    Browse the repository at this point in the history
  2. Update packages/edit-site/src/components/global-styles/typography-uti…

    …ls.js
    
    
    My blod is typo
    
    Co-authored-by: Andrew Serong <14988353+andrewserong@users.noreply.github.com>
    ramonjd and andrewserong committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    99382a7 View commit details
    Browse the repository at this point in the history