Nav block: extract hook for inner blocks #42743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Code Quality
getdave
requested review from
draganescu,
scruffian,
talldan,
MaggieCabrera and
ajlende
getdave
commented
Jul 27, 2022
Comment on lines
+199
to
197
| const hasSubmenus = !! innerBlocks.find( | ||
| ( block ) => block.name === 'core/navigation-submenu' | ||
| ); |
There was a problem hiding this comment.
This concept of "submenus" was previously baked into the useSelect which handled information about inner blocks.
I find the concept to be unrelated to the extent that it should not be included in the hook.
|
Size Change: +8 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
getdave
force-pushed
the
try/extract-hook-for-uncontrolled-inner-blocks
branch
from
af8bbe9
to
3573125
Compare
|
Waiting on tests... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Extracts a new hook for handling inner blocks related things.
Also removes unrelated concept of "submenus" from scope of the exported data.
Why?
Having this within the body of the
edit.jsfile was making it very verbose and noisy. This PR reduces noisy and is part of an effort to make the block more approachable by codify concepts.How?
Extracts a custom hook for inner blocks related things.
Testing Instructions
Basically check the block doesn't break in any major way.
Especially worth checking that submenus still work as expected.
Screenshots or screencast