BorderControl: Add box sizing reset #42754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Feature] UI Components
|
Size Change: +16 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
|
This approach is quite similar to what I had in mind when writing this comment in the original issue. Curious to see what @mirka thinks |
mirka
approved these changes
Jul 28, 2022
aaronrobertshaw
force-pushed
the
add/box-sizing-reset-to-border-controls
branch
from
09a800e to
7c2974b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
box-sizingreset styles #42415What?
boxSizingResetstyle to be used as a "mixin" for Emotion css/styled-components.boxSizingResetto reset theBorderControls box-sizingNote: There's every chance that there's a better approach to a box sizing reset, so I'm happy to abandon this if desired.
Why?
How?
boxSizingResetutils/style-mixinsBorderControl's root style.Testing Instructions
BorderControlandBorderBoxControl's color indicator is brokenScreenshots or screencast