Global Styles: Add block spacing to root block support UI #42797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
Global Styles
|
Size Change: +286 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
andrewserong
commented
Jul 29, 2022
andrewserong
changed the title
30 tasks
|
This tested well for me. The only thing I noticed is that blockgap.mp4Not sure where the 24px comes from 🤔 Block gap in the theme.json is set to 1.5rem. |
|
Thanks for testing @glendaviesnz!
Which theme did you have active? I'm assuming it was TwentyTwentyTwo if the theme.json has the value set to I'll do some more testing. |
It was TT1 blocks with the following added to theme.json settings: |
@glendaviesnz is that in The blockGap value should be in |
🤦 Doh - works as expected when put in the right place, ie. 'Reset all' returns the Block gap value in global styles to the value in theme.json |
glendaviesnz
approved these changes
Aug 8, 2022
There was a problem hiding this comment.
This worked as advertised for me.
✅ Changes to block gap in global styles reflected in site editor canvas
✅ Changes saved to block gap in global styles reflected in site front end
✅ Resetting block gap in global styles resets to default value from theme.json
✅ Setting block gap at block level in global styles or page editor continues to work as expected
|
Thanks for the reviews @glendaviesnz, much appreciated! |
andrewserong
deleted the
update/add-block-gap-to-root-block-supports-in-global-styles
branch
57 tasks
andrewserong
added
the
[Feature] Layout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add
blockGap/ block spacing to the root Layout global styles panel.Why?
Now that the Layout refactor in #40875 has resolved the hierarchy of blockGap style output, we should be able to safely add back in the UI for the root level control.
How?
blockGapto the list ofROOT_BLOCK_SUPPORTShasGapValueandhasPaddingValuechecks so that they check against whether or not a user value has been provided. This resolves an issue at the root level for both style value types where the ToolsPanel dropdown menu would still display the item as though it had a value even after it has been reset.Testing Instructions
settings.spacing.blockGapis set to eithernullorfalseScreenshots or screencast