Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Block: update document links in templates #42839

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

t-hamano
Copy link
Contributor

@t-hamano t-hamano commented Jul 31, 2022

What?

This PR updates the document links in the template file that create-block generates by default and create-block-tutorial-template.

Why?

I found the following links are redirected and one anchor link doesn't work properly:

How?

Just update links.

Testing Instructions

  • Run node ./path/to/gutenberg/node_modules/.bin/wp-create-block gutenpride
  • Confirm that there are no redirects and the anchor links work correctly when you open document links listed in files in the gutenpride directory.

@t-hamano t-hamano added [Type] Developer Documentation Documentation for developers [Tool] Create Block /packages/create-block labels Jul 31, 2022
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch. It looks like all those links have changed since the templates were authored.

@gziolo gziolo merged commit 53bb298 into trunk Aug 2, 2022
@gziolo gziolo deleted the create-block/update-doc-link branch August 2, 2022 08:24
@github-actions github-actions bot added this to the Gutenberg 13.9 milestone Aug 2, 2022
@bph bph added the Needs Dev Note Requires a developer note for a major WordPress release cycle label Sep 14, 2022
@bph bph mentioned this pull request Sep 14, 2022
89 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Dev Note Requires a developer note for a major WordPress release cycle [Tool] Create Block /packages/create-block [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants