Rename solid color #42918
Merged
Rename solid color #42918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Enhancement
|
Size Change: -5 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
|
Thanks for the PR. I wonder if 'Spot' might be better than 'Solid'? This is quite possibly my subjective interpretation, but 'solid' seems analogous with 'opaque', but since we now support alpha channels these colors won't necessarily be 'solid' in that sense. Just a thought. Otherwise the changes look good. Edit: I just noticed that Figma refer to these colors as 'solid', so I was probably overthinking :)
Related (just FYI): #41904 (comment) #42320 |
|
Oh nice, the focus style in #41904 (comment) is a VAST improvement! Let's make that happen. |
jameskoster
approved these changes
Aug 3, 2022
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Followup to #41937 (comment). Renames "Solid color" to just "Solid".
Why?
Color feels implied, and the singular words feel more actionable.
Before:
After:
Note that there's a bit more work to do here. The padding feels awkward especially above the tabs. But That's likely best solved separately.
Testing Instructions
Please test a cover block background and see the two tab options.