Combine style-engine stores for block-supports #42970
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Right now we have a separate store for
layout-block-supports
and genericblock-supports
.The result is that on the frontend the CSS gets printed like this: (notice there are 2 separate
<style>
elements, each one with a different ID)This PR uses the
block-supports
store for layouts as well.The result is this:
The
<style>
elements get combined and everything else remains the same.The benefit of doing this is that as we convert all implementations to use the style engine, common selectors and declarations can be combined resulting in further optimizations of our styles. The more we add to the same store, the more it can be optimized.