Fix/42097 #42991
Closed
Fix/42097 #42991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -163 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧🚧🚧🚧🚧🚧 Still a WIP 🚧🚧🚧🚧🚧🚧🚧🚧🚧🚧
What?
In #41934 we made global-styles a dependency of blocks, so that the global styles load first. This is because we output the block level user settings as part of the inline CSS for each block, so it needs to load after the main Global Styles CSS.
Note: I am still thinking about whether this is indeed the correct approach.
We need to make the same change in the Post and Site editors so we have a consistent view in all places.
Fixes #42097
How?
This is quite complex and there are several different things we need to do.
global-styles-css-custom-properties, so we inject editor styles into this. We should probably only do this for global styles not the other editor styles.Testing Instructions
TBD
Screenshots or screencast
TBD