[RNMobile] Set tintColor for ActionSheetIOS #42996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SiobhyB
added
the
Mobile App - i.e. Android or iOS
SiobhyB
added
the
Mobile App - Automation
SiobhyB
pushed a commit
to wordpress-mobile/WordPress-iOS
that referenced
this pull request
Aug 4, 2022
These calls are going to be replaced with direct calls in Gutenberg: WordPress/gutenberg#42996
|
Size Change: 0 B Total Size: 1.27 MB ℹ️ View Unchanged
|
4 tasks
added 2 commits
August 5, 2022 17:21
'usePreferredColorScheme' is used instead of 'usePreferredColorSchemeStyle' as only a hex code needs to be passed as a tintColor.
The UI tests in Gutenberg Mobile were failing as 'styles' returns 'undefined' (in the tests) when called from the 'PickerComponent' function. Example: https://app.circleci.com/pipelines/github/wordpress-mobile/gutenberg-mobile/18255/workflows/16df0260-7972-465b-b400-ec37603dfd9e/jobs/100060 This commit seeks to workaround that error by only calling the internal styles from the main Picker class.
|
I've created a separate PR to update all the CSS selectors in the picker's files to follow BEM naming convention at #43036. (I didn't want to send this PR off-course by doing it directly here, but also didn't want to leave the component's |
dcalhoun
approved these changes
Aug 5, 2022
Comment on lines
+23
to
+29
| .components-picker__button-title { | ||
| color: $blue-50; | ||
| } | ||
|
|
||
| .components-picker__button-title--dark { | ||
| color: $blue-30; | ||
| } |
There was a problem hiding this comment.
These static colors make sense to me for the current goal — a consistent color within the editor. Long term, I would imagine we should revert this change so that the host app once again can control the picker colors.
…incorporate-consistent-tint-color
SiobhyB
pushed a commit
that referenced
this pull request
Sep 1, 2022
* Set tintColor on action sheets for iOS * [Code quality] Replace hex codes with CSS * [Code quality] Refine 'buttonTitleColor' const * Refactor code to use 'usePreferredColorScheme' 'usePreferredColorScheme' is used instead of 'usePreferredColorSchemeStyle' as only a hex code needs to be passed as a tintColor. * Refactor to workaround test failures The UI tests in Gutenberg Mobile were failing as 'styles' returns 'undefined' (in the tests) when called from the 'PickerComponent' function. Example: https://app.circleci.com/pipelines/github/wordpress-mobile/gutenberg-mobile/18255/workflows/16df0260-7972-465b-b400-ec37603dfd9e/jobs/100060 This commit seeks to workaround that error by only calling the internal styles from the main Picker class. Co-authored-by: David Calhoun <438664+dcalhoun@users.noreply.github.com>
4 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs
gutenberg-mobile: [RNMobile] Set tintColor for ActionSheetIOS wordpress-mobile/gutenberg-mobile#5074What?
This PR explicitly sets a
tintColoron the ActionSheetIOS component.Why?
At the moment, the
tintColoris not explicitly defined and it's easy for it be unintentionally overridden by host apps. Explicitly setting the value will avoid any unintentional overides.How?
The ActionSheetIOS component's
tintColorprop is used in combination with theusePreferredColorSchemehook to set different colours for light/dark mode.Testing Instructions
add image. Another option for accessing the component is to tap the ellipsis in the bottom right of a block for the actions menu.Screenshots or screencast