Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README, add CONTRIBUTING #431

Merged
merged 1 commit into from
Apr 17, 2017
Merged

Conversation

jasmussen
Copy link
Contributor

Per discussion in WordPress slack office hours this past Wednesday, this PR seeks to clarify the developer contribution workflow by adding a new separate contribution document. In this I expanded on how to name branches, and branch off master.

Context: https://wordpress.slack.com/archives/C02QB2JS7/p1492017131774539

Per discussion in WordPress slack office hours this past Wednesday, this PR seeks to clarify the developer contribution workflow by adding a new separate contribution document. In this I expanded on how to name branches, and branch off master.

Context: https://wordpress.slack.com/archives/C02QB2JS7/p1492017131774539
@jasmussen jasmussen added the [Type] Developer Documentation Documentation for developers label Apr 17, 2017
@jasmussen jasmussen self-assigned this Apr 17, 2017
@jasmussen jasmussen requested a review from nylen April 17, 2017 07:25
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it 🚢

@jasmussen jasmussen merged commit dd170cc into master Apr 17, 2017
@jasmussen jasmussen deleted the add/readme-contrib-instructions branch April 17, 2017 08:22

If you'd like to try or contribute to the plugin, you can clone this repo into your `wp-content/plugins` directory, then activate the plugin. You'll get a separate WordPress menu item called Gutenberg.

Be sure to have <a href="https://nodejs.org/en/">Node installed first</a>. Then, in a terminal, type `npm install` to get the dependencies all set up. Once that finishes, you can type `npm run build` to make the plugin functional, or `npm run dev` to keep the plugin building in the background as you work on it.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depending on how much depth we want to go into here, I see this step being the main road bump along the way to getting started. We could add a little more detail about navigating to the plugin directory in the terminal. We could reference that the equivalent to terminal in Windows is the Command Prompt. We might even want to go into some detail (or link to references) about how to set up a local WordPress environment, or directories to find a local install for popular tools (default OSX Apache folder, MAMP, Desktop Server).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will make a personal ToDo note to expand this section one of these days. Running out of steam for today :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants