Home Link: Fix undo trap #43112
Merged
Home Link: Fix undo trap #43112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
|
Size Change: -1 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
t-hamano
approved these changes
Aug 11, 2022
|
Thank you, @t-hamano! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
See: #8119
PR fixes undo trap caused by the Home Link block.
P.S. I also removed
clientIdfrom the dependency list since it wasn't used.Why?
The block uses a side-effect to set the default label value when inserted. Similar side-effects should create undo records.
Testing Instructions
Screenshots or screencast
Before
CleanShot.2022-08-10.at.11.35.03.mp4
After
CleanShot.2022-08-10.at.11.38.34.mp4