Navigation: Try to improve the appender in an empty block #43115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Block] Navigation
jasmussen
requested review from
ellatrix,
tellthemachines and
ajitbohra
as code owners
|
Size Change: +4 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
This was referenced Aug 11, 2022
|
This PR will need a rebase and slight change in direction based on #43169. |
jasmussen
force-pushed
the
try/nav-setup-polish
branch
from
564b80a
to
7b55b3b
Compare
|
This has been rebased and is now vastly simpler because of #43169 landing:
|
ajlende
approved these changes
Aug 15, 2022
There was a problem hiding this comment.
👍 Looks good to me. This is what I saw during my testing.
Empty menu
trunk
try/nav-setup-polish
Other Results
The rest of the results are identical between trunk and this branch.
Screenshots
Full menu
trunk
try/nav-setup-polish
Empty submenu
trunk
try/nav-setup-polish
Full submenu
trunk
try/nav-setup-polish
Mobile
trunk
try/nav-setup-polish
82 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
When you create a new navigation menu (Switch menu > Create menu at the moment), you get a big black plus:
This PR fixes that by scoping some rules and moving some code around, and also fixes the black plus:
There's an opportunity for a better fix there, as the nav block at the moment uses the "button block appender". It does this so that the appender can be permanently visible in submenus (see #37572 for more conversation). But this is a divergence that would be good to revisit.
Testing Instructions
Please test the nav block with empty, full menus, submenus, with and without responsive.
Edit: Updated description per new goals as of #43115 (comment)