-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Blocks] Paragraph and Heading: add gradient support #43119
Conversation
Considering the option for Gradient exists with the Code, Pullquote, and Quote blocks, this makes sense (and moves us closer to overall block settings consistency). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@MaggieCabrera Thanks! It would be great also to add gradient support to the Heading block. |
Maybe we can keep the issue open and update the title because I would hate to loose the suggestion for gradient texts 😆 |
Added label |
@carolinan Gradient texts... like so? https://bg.design/bright-mode/ |
Like #30982 Right now we are checking for accesibility issues with text colors, right? For text gradients it would be the same, but testing all the colors involved in the gradient, am I right? |
removed |
What?
Adds gradient supports for paragraph and heading blocks
Closes #30982
Part of #41113
Why?
Before we had a way to hide block settings from the sidebar we had to be careful about what we were exposing in the UI, that is not the case anymore and we can add supports as users need them more freely without fearing UI clutter.
How?
Just added the support to block.json :D
Testing Instructions
Open the editor and change the background of the block to a gradient! Then check the frontend too.
Screenshots or screencast
Tested on emptytheme:
/cc @WordPress/block-themers