[Style Engine]: Defensive guarding for when style does not define the 'individual' property #43122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #43121
What?
This PR adds defensive guarding to protect against when the style
$property_keys
do not define the'individual'
property.Why?
Prevents a PHP Notice "Undefined index: individual" from being thrown in
WP_Style_Engine::get_css_declarations()
when a style is not an'individual'
.How?
It bails out early by not iterating through the array of
$style_value
. Why? None of that style isindividual
.Testing
WP_DEBUG
and run the PHPUnit tests. How?Add the following code about loading Composer deps in the
phpunit/bootstrap.php
file:Step 3: Apply this patch.
Step 4: Run the PHPUnit tests again. The above PHP Notice is resolved.
Notes:
PR #41302 turns on debug mode for testing PHP notices and deprecations.