-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark which attributes of the image should be considered content #43280
Conversation
I've tried this with an external image (only <?php
/**
* Title: demo pattern
* Slug: twentytwentytwo/demo-pattern
* Categories: text
* Block Types: core/paragraph, core/image
*/
?>
<!-- wp:paragraph {"backgroundColor":"pale-cyan-blue"} -->
<p class="has-pale-cyan-blue-background-color has-background">hi rigatonious</p>
<!-- /wp:paragraph -->
<!-- wp:image {"style":{"border":{"width":"18px"}},"className":"is-style-rounded"} -->
<figure class="wp-block-image has-custom-border is-style-rounded"><img src="https://images.unsplash.com/photo-1544005313-94ddf0286df2?ixlib=rb-1.2.1&ixid=MnwxMjA3fDB8MHxzZWFyY2h8NHx8cGVyc29ufGVufDB8fDB8fA%3D%3D&w=1000&q=80" alt="" style="border-width:18px"/></figure>
<!-- /wp:image --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
I've been thinking on situations in which this could break the "transform to pattern" feature. I've found none. In theory, one use case that could render a failure is this:
In this case, because of how the transforms to pattern works, the resulting image would have the url of the source image and teh id of the pattern. In practice, though, I can't see this happening: the pattern would need to provide an ID for the site's media library, which changes from site to site. |
I've just tried what happens when an image has a wrong ID. The block appears as invalid: So, in the very unlikely situation the above can happen, the resulting state is that the user ends up with an image that is invalid and that can self-correct by clicking "Attempt block recovery". I think this is a fairly safe situation. |
Exactly |
Related #43037 #43038
This PR marks which attributes of the image block should be considered content. This affects two features:
Gravacao.de.ecra.a.partir.de.16-08-2022.18.58.30.webm
Gravacao.de.ecra.a.partir.de.16-08-2022.19.00.40.webm