Fix legacy widget form positioning in customizer #43297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
|
Size Change: +66 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
67 tasks
noisysocks
approved these changes
Aug 23, 2022
talldan
force-pushed
the
fix/legacy-widget-form-positioning
branch
from
bae1a86 to
ec5eda2
Compare
I reduced it down a bit. The sidebar is wider for me with scrollbars always active which makes it difficult to find a balance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes issues with the legacy widget form popover in the customizer as mentioned in this comment - #42971 (review).
Why?
Since the refactor of the Popover component this has been a buggy. Users are unable to access the full form if it takes up more than the height of the browser window.
How?
__unstableShiftprop to ensure the popover remains in the viewportoffsetprop to move the popover to the right morepositionforplacement.Testing Instructions
Screenshots or screencast
Before
Kapture.2022-08-17.at.13.14.26.mp4
After
Kapture.2022-08-17.at.13.09.59.mp4