Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group: Add missing typography supports #43308

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

aaronrobertshaw
Copy link
Contributor

Related:

What?

Adds missing typography support to the Group block.

Why?

  • Improves consistency of our design tools across blocks.

How?

  • Opts into missing typography supports.

Testing Instructions

  1. Edit a post, add a Group block with multiple paragraphs inside it.
  2. Select the Group block and confirm font family and text decoration controls are available.
  3. Test various typography settings ensuring styles are applied in the editor.
  4. Save and confirm the application on the frontend.
  5. Switch to the site editor.
  6. Navigate to Global Styles > Blocks > Group > Typography and apply typography styles there.
  7. Confirm the selected styles are reflected in the preview and on the frontend.

Screenshots or screencast

Screen.Recording.2022-08-17.at.5.42.41.pm.mp4

@aaronrobertshaw aaronrobertshaw added [Type] Enhancement A suggestion for improvement. [Block] Group Affects the Group Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Typography Font and typography-related issues and PRs labels Aug 17, 2022
@aaronrobertshaw aaronrobertshaw self-assigned this Aug 17, 2022
Copy link
Contributor

@andrewserong andrewserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working nicely for me in the post editor and global styles, and on the site frontend. It only just occurred to me from playing with this that it's quite handy having all the typography controls available at the Group level so that you can quickly set the font family (or for a particular aesthetic purpose strikethrough or underline) for a section of text across a few different blocks.

image

LGTM! ✨

@aaronrobertshaw aaronrobertshaw merged commit b2fec2a into trunk Aug 19, 2022
@aaronrobertshaw aaronrobertshaw deleted the add/missing-typography-supports-to-group branch August 19, 2022 06:23
@github-actions github-actions bot added this to the Gutenberg 14.0 milestone Aug 19, 2022
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Group Affects the Group Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Typography Font and typography-related issues and PRs Needs User Documentation Needs new user documentation [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants